| Summary: | Move LibWebRTCMediaEndpoint data channel code to LibWebRTCDataChannelHandler | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alex, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2018-08-30 21:26:38 PDT
Created attachment 348593 [details]
Patch
Created attachment 348601 [details]
Patch
Comment on attachment 348601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348601&action=review LGTM > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:750 > + auto& connection = protectedThis->m_peerConnectionBackend.connection(); > + connection.fireEvent(LibWebRTCDataChannelHandler::channelEvent(*connection.scriptExecutionContext(), WTFMove(dataChannel))); You can avoid the connection variable. > > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:750
> > + auto& connection = protectedThis->m_peerConnectionBackend.connection();
> > + connection.fireEvent(LibWebRTCDataChannelHandler::channelEvent(*connection.scriptExecutionContext(), WTFMove(dataChannel)));
>
> You can avoid the connection variable.
Right, I think it reads better as two lines though.
Comment on attachment 348601 [details] Patch Clearing flags on attachment: 348601 Committed r235552: <https://trac.webkit.org/changeset/235552> All reviewed patches have been landed. Closing bug. |