Bug 189173

Summary: convertToRegExpMatchFastGlobal must use KnownString as the child use kind
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
saam: review-
patch
msaboff: review+
patch for landing none

Description Saam Barati 2018-08-30 14:05:23 PDT 
We emit this node after a node that does side effects, so it's no longer valid to exit at that node. We also emit type checks on these edges before this node and before the side effect, so KnownString is the valid UseKind to use.
Comment 1 Saam Barati 2018-08-30 14:06:03 PDT 
<rdar://problem/43501645>
Comment 2 Saam Barati 2018-08-30 14:15:54 PDT 
Created attachment 348547 [details]
patch
Comment 3 Saam Barati 2018-08-30 14:25:47 PDT 
Comment on attachment 348547 [details]
patch

Need to fix some assertions
Comment 4 Saam Barati 2018-08-30 14:33:43 PDT 
Created attachment 348552 [details]
patch
Comment 5 Michael Saboff 2018-08-30 14:43:19 PDT 
Comment on attachment 348552 [details]
patch

r=me
Comment 6 Saam Barati 2018-08-30 16:07:02 PDT 
Created attachment 348562 [details]
patch for landing
Comment 7 WebKit Commit Bot 2018-08-31 00:45:10 PDT 
Comment on attachment 348562 [details]
patch for landing

Clearing flags on attachment: 348562

Committed r235538: <https://trac.webkit.org/changeset/235538>
Comment 8 WebKit Commit Bot 2018-08-31 00:45:12 PDT 
All reviewed patches have been landed.  Closing bug.