Bug 189092

Summary:

[iOS] Update color picker to match design feedback

Product:

WebKit

Reporter:

Aditya Keerthi <pxlcoder>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

achristensen, bdakin, cdumez, ews-watchlist, skidrow06, thorton, wenson_hsieh

Priority:

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none

Description Aditya Keerthi 2018-08-29 11:49:14 PDT

The color well on iOS should look more like macOS.

iPad: The corners of the color picker should not be rounded.

iPhone: The color picker should not have an edge-to-edge design and should respect the safe area on iPhone X.

Comment 1 Aditya Keerthi 2018-08-29 12:08:55 PDT

Created attachment 348419 [details]
Patch

Comment 2 EWS Watchlist 2018-08-29 14:06:38 PDT

Comment on attachment 348419 [details]
Patch

Attachment 348419 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9026087

New failing tests:
fast/forms/color/input-appearance-color.html

Comment 3 EWS Watchlist 2018-08-29 14:06:40 PDT

Created attachment 348429 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

Comment 4 Aditya Keerthi 2018-08-29 17:13:44 PDT

Created attachment 348453 [details]
Patch

Comment 5 Alex Christensen 2021-11-01 12:51:09 PDT

Comment on attachment 348453 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.