| Summary: | IDBDatabase should not return true to hasPendingActivity after being stopped | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, beidson, commit-queue, darin, ews-watchlist, jsbell, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2018-08-28 20:32:36 PDT
Created attachment 348384 [details]
Patch
Comment on attachment 348384 [details]
Patch
No way to make a regression test?
(In reply to Darin Adler from comment #2) > Comment on attachment 348384 [details] > Patch > > No way to make a regression test? AFAIUI, IDBDatabase::hasPendingActivity will stop returning true once transactions are finalized which will happen ultimately, but not always before GC calls IDBDatabase::hasPendingActivity for the first time. This patch makes IDBDatabase GC-collectable sooner but I do not think it makes some leaked IDBDatabase no longer leaking, so there is no easy way to add a test for that change. This will be captured with bug 189018, which asserts that a stopped ActiveDOMObject hasPendingActivity to return false. Without this patch, some IDB tests would crash. Comment on attachment 348384 [details] Patch Clearing flags on attachment: 348384 Committed r235456: <https://trac.webkit.org/changeset/235456> All reviewed patches have been landed. Closing bug. |