Bug 188949

Summary:

[Apple Pay] Introduce new values for -apple-pay-button-type

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, andersca, bfulgham, commit-queue, ews-watchlist, pvollan, rniwa, sam, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none
Patch	none
Patch	none

Andy Estes

Reported 2018-08-25 13:41:13 PDT

[Apple Pay] Introduce new values for -apple-pay-button-type

Attachments
Patch (92.12 KB, patch) 2018-08-25 13:50 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.87 MB, application/zip) 2018-08-25 15:16 PDT, EWS Watchlist	no flags	Details
Patch (146.37 KB, patch) 2018-08-25 15:46 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (223.61 KB, patch) 2018-08-26 19:01 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (223.55 KB, patch) 2018-08-26 19:53 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2018-08-25 13:43:04 PDT

rdar://problem/39992228

Andy Estes

Comment 2 2018-08-25 13:50:29 PDT Comment hidden (obsolete)

Created attachment 348082 [details] Patch

EWS Watchlist

Comment 3 2018-08-25 15:16:05 PDT Comment hidden (obsolete)

Comment on attachment 348082 [details] Patch Attachment 348082 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8983360 New failing tests: http/tests/ssl/applepay/ApplePayButton.html

EWS Watchlist

Comment 4 2018-08-25 15:16:07 PDT Comment hidden (obsolete)

Created attachment 348083 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Andy Estes

Comment 5 2018-08-25 15:46:18 PDT Comment hidden (obsolete)

Created attachment 348085 [details] Patch

Andy Estes

Comment 6 2018-08-26 19:01:58 PDT Comment hidden (obsolete)

Created attachment 348110 [details] Patch

Andy Estes

Comment 7 2018-08-26 19:53:43 PDT

Created attachment 348111 [details] Patch

WebKit Commit Bot

Comment 8 2018-08-26 20:32:57 PDT

Comment on attachment 348111 [details] Patch Clearing flags on attachment: 348111 Committed r235349: <https://trac.webkit.org/changeset/235349>