Bug 188870

Summary:

HTML{Image, Link, Script}Element::crossOrigin() should return an AtomicString

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED LATER

Severity:

Normal

CC:

ahmad.saleem792, cdumez, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2018-08-22 17:01:28 PDT

HTML{Image, Link, Script}Element::crossOrigin() should return an "const AtomicString&" as opposed to a String so as to avoid unnecessary ref-count churn and the need for a caller to perform string comparisons.

Attachments
Patch (9.74 KB, patch) 2018-08-22 17:09 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-08-22 17:09:18 PDT

Created attachment 347878 [details] Patch

Ahmad Saleem

Comment 2 2023-09-20 09:05:23 PDT

Do we need this now? - @Ryosuke & @Chris?

Ryosuke Niwa

Comment 3 2023-09-25 08:44:44 PDT

We don't need to do this per se.

Note You need to log in before you can comment on or make changes to this bug.