Bug 188863

Summary:

Remove privateBrowsingEnabled from NetworkProcessCreationParameters

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

achristensen

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	achristensen: review-

Description Sihui Liu 2018-08-22 13:58:35 PDT

We should send a message to network process to create a privateBrowsing session instead of using the creation parameter.

Comment 1 Sihui Liu 2018-08-22 14:01:49 PDT

Created attachment 347844 [details]
Patch

Comment 2 Alex Christensen 2018-08-23 11:09:40 PDT

Comment on attachment 347844 [details]
Patch

This doesn't accomplish anything useful except separating a message into two messages.

Comment 3 Sihui Liu 2018-08-23 16:16:09 PDT

I was trying to remove the whole networkProcessCreationParameters, aiming to stop the initializing network process from processPool. But it seems we still need to send a lot of setting messages through webprocesspool, so I am not sure if this is a correct idea now...

Comment 4 Alex Christensen 2018-08-23 16:30:57 PDT

Comment on attachment 347844 [details]
Patch

You only need to remove the NetworkProcessCreationParameters members that come from a WebProcessPool.  This one comes from a static function WebPreferences::anyPagesAreUsingPrivateBrowsing