Bug 188827

Summary: Translate 4 tests using WKPageLoaderClient to ObjC
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch that applies
none
patch
none
Patch
none
Build fix
none
Patch
none
patch with updated title none

Alex Christensen
Reported 2018-08-21 16:33:34 PDT
Translate 4 tests using WKPageLoaderClient to ObjC
Attachments
Patch (74.37 KB, patch)
2018-08-21 16:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch that applies (73.91 KB, patch)
2018-08-21 16:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (73.93 KB, patch)
2018-08-21 17:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (74.48 KB, patch)
2018-08-27 09:02 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Build fix (1.88 KB, patch)
2018-08-27 09:28 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (75.27 KB, patch)
2018-08-27 11:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch with updated title (74.81 KB, patch)
2018-08-27 11:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-21 16:38:44 PDT
Created attachment 347725 [details] Patch
Alex Christensen
Comment 2 2018-08-21 16:57:40 PDT
Created attachment 347730 [details] patch that applies
Alex Christensen
Comment 3 2018-08-21 17:20:19 PDT
Created attachment 347739 [details] patch
Tim Horton
Comment 4 2018-08-21 17:32:34 PDT
Comment on attachment 347739 [details] patch rs=me
Alex Christensen
Comment 5 2018-08-27 09:02:37 PDT
Created attachment 348145 [details] Patch
Alex Christensen
Comment 6 2018-08-27 09:08:39 PDT
I don't know why it's having such a hard time applying the patch. http://trac.webkit.org/r235367
Radar WebKit Bug Importer
Comment 7 2018-08-27 09:09:21 PDT
<rdar://problem/43756020>
Don Olmstead
Comment 8 2018-08-27 09:23:23 PDT
This broke the CMake builds
Don Olmstead
Comment 9 2018-08-27 09:28:10 PDT
Created attachment 348150 [details] Build fix Files didn't get removed from CMake.
Don Olmstead
Comment 10 2018-08-27 09:30:34 PDT
Alex beat me to the fix. Marking as resolved
Alex Christensen
Comment 11 2018-08-27 11:13:30 PDT
Reopening to attach new patch.
Alex Christensen
Comment 12 2018-08-27 11:13:30 PDT
Created attachment 348168 [details] Patch
Alex Christensen
Comment 13 2018-08-27 11:14:25 PDT
Created attachment 348169 [details] patch with updated title
Alex Christensen
Comment 14 2018-08-27 12:38:45 PDT
https://trac.webkit.org/changeset/235391/webkit
Note You need to log in before you can comment on or make changes to this bug.