| Summary: | Translate 4 tests using WKPageLoaderClient to ObjC | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | don.olmstead, thorton, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Alex Christensen
2018-08-21 16:33:34 PDT
Created attachment 347725 [details]
Patch
Created attachment 347730 [details]
patch that applies
Created attachment 347739 [details]
patch
Comment on attachment 347739 [details]
patch
rs=me
Created attachment 348145 [details]
Patch
I don't know why it's having such a hard time applying the patch. http://trac.webkit.org/r235367 This broke the CMake builds Created attachment 348150 [details]
Build fix
Files didn't get removed from CMake.
Alex beat me to the fix. Marking as resolved Reopening to attach new patch. Created attachment 348168 [details]
Patch
Created attachment 348169 [details]
patch with updated title
|