Bug 188824

Summary:

Web Inspector: Address some ESLint warnings

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	mattbaker: review+

Description Joseph Pecoraro 2018-08-21 15:40:54 PDT

Address some ESLint warnings

A few were real logic mistakes.

Comment 1 Joseph Pecoraro 2018-08-21 15:41:46 PDT

Created attachment 347715 [details]
[PATCH] Proposed Fix

Comment 2 Matt Baker 2018-08-21 15:55:28 PDT

Comment on attachment 347715 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=347715&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:39
> +            if (!(newTestSuite instanceof WI.AuditTestSuite))

Yikes

Comment 3 Joseph Pecoraro 2018-09-10 16:47:59 PDT

<https://trac.webkit.org/changeset/235873/webkit>

Comment 4 Radar WebKit Bug Importer 2018-09-10 16:48:47 PDT

<rdar://problem/44322766>