| Summary: | [GStreamer] Extra ASSERTs at MainThreadNotifier | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||
| Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, ews-watchlist, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Xabier Rodríguez Calvar
2018-08-21 05:08:09 PDT
Created attachment 347630 [details]
Patch
It looks like the MainThread notifier could have these two extra checks in debug mode.
Attachment 347630 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Build Bot from comment #2) > ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and > description [changelog/filechangedescriptionwhitespace] [5] > ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and > description [changelog/filechangedescriptionwhitespace] [5] > Total errors found: 2 in 2 files Weird, local check said nothing... Created attachment 349012 [details]
Patch for landing
(In reply to Xabier Rodríguez Calvar from comment #3) > (In reply to Build Bot from comment #2) > > ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and > > description [changelog/filechangedescriptionwhitespace] [5] > > ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and > > description [changelog/filechangedescriptionwhitespace] [5] > > Total errors found: 2 in 2 files > > Weird, local check said nothing... Because style checks are done before opening the changelogs. Comment on attachment 349012 [details] Patch for landing Clearing flags on attachment: 349012 Committed r235732: <https://trac.webkit.org/changeset/235732> All reviewed patches have been landed. Closing bug. |