Bug 188737

Summary: Forgetting to call noResult in DFGSpeculativeJIT leads to hard to diagnose crashes
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: NEW ---    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Saam Barati 2018-08-19 18:33:58 PDT 
We should probably just make the thing that calls compileNode do this.

I just spend 30 minutes figuring out why a crash was happening, and it was because I forgot to call noResult(node) for a node I'm implementing.
Comment 1 Saam Barati 2018-08-19 22:03:35 PDT 
We pass various arguments to noResult that could be hard to infer. We should probably just have an assert that it gets called exactly once for each node that doesn't have a result