| Summary: | Remove unused subresourceIntegrityEnabled setting/preference | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||||||||||||
| Status: | RESOLVED WONTFIX | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | cdumez, dbates, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, kondapallykalyan, rniwa | ||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Alex Christensen
2018-08-15 09:22:49 PDT
Created attachment 347165 [details]
Patch
Created attachment 347167 [details]
Patch
Comment on attachment 347167 [details] Patch Attachment 347167 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8868845 New failing tests: http/tests/subresource-integrity/sri-disabled-with-setting.html Created attachment 347174 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347167 [details] Patch Attachment 347167 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8868892 New failing tests: http/tests/subresource-integrity/sri-disabled-with-setting.html Created attachment 347176 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 347167 [details] Patch Attachment 347167 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8869048 New failing tests: http/tests/subresource-integrity/sri-disabled-with-setting.html Created attachment 347179 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347167 [details] Patch Attachment 347167 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8869079 New failing tests: http/tests/subresource-integrity/sri-disabled-with-setting.html Created attachment 347181 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Title is misleading. The setting is used. It is just enabled by default. Although I don’t recall many issues with subresource integrity having a setting to toggle “a security policy” feature is always nice for debugging and triaging. Created attachment 347185 [details]
Patch
I think it's unused code, but if you feel that it's useful to have around, Dan, feel free to r- Comment on attachment 347185 [details] Patch Attachment 347185 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8870645 New failing tests: http/tests/subresource-integrity/sri-enabled-with-setting.html Created attachment 347197 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347185 [details] Patch Attachment 347185 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8870709 New failing tests: http/tests/subresource-integrity/sri-enabled-with-setting.html Created attachment 347200 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 347185 [details] Patch Attachment 347185 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8870546 New failing tests: http/tests/subresource-integrity/sri-enabled-with-setting.html Created attachment 347202 [details]
Archive of layout-test-results from ews114 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347185 [details] Patch Attachment 347185 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8871016 New failing tests: http/tests/subresource-integrity/sri-enabled-with-setting.html Created attachment 347208 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
|