| Summary: | [LFC][Floating] Do not confuse clear with clearance. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2018-08-13 18:24:28 PDT
Created attachment 347060 [details]
Patch
Comment on attachment 347060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347060&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.h:60 > + void computeVerticalPositionForClear(const FloatingContext&, const Box&, Display::Box&) const; I would like to see the word "float" somewhere in the function name. > Source/WebCore/layout/layouttree/LayoutBox.h:65 > + bool hasClear() const; This name sounds a bit too generic. Maybe hasFloatClear, or clearsFloats? Committed r234834: <https://trac.webkit.org/changeset/234834> |