Bug 188534

Summary: Web Inspector: Table should handle row selection instead of the table delegate
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Matt Baker 2018-08-13 14:47:33 PDT 
To prevent selection, the table delegate can implement `tableShouldSelectRow`, similar to NSTableViewDelegate's shouldSelectRow.
Comment 1 Radar WebKit Bug Importer 2018-08-13 14:47:57 PDT 
<rdar://problem/43253335>
Comment 2 Matt Baker 2018-08-13 14:54:18 PDT 
Created attachment 347043 [details]
Patch
Comment 3 Joseph Pecoraro 2018-08-13 15:01:36 PDT 
Comment on attachment 347043 [details]
Patch

r=me
Comment 4 Joseph Pecoraro 2018-08-13 15:02:29 PDT 
Comment on attachment 347043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347043&action=review

> Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js:43
> +    tableShouldSelectRow(table, cell, column, rowIndex)

This should be under the delegate section (~20 lines down), not the data source.
Comment 5 Matt Baker 2018-08-13 15:05:23 PDT 
Created attachment 347047 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-08-13 15:44:25 PDT 
Comment on attachment 347047 [details]
Patch for landing

Clearing flags on attachment: 347047

Committed r234822: <https://trac.webkit.org/changeset/234822>
Comment 7 WebKit Commit Bot 2018-08-13 15:44:26 PDT 
All reviewed patches have been landed.  Closing bug.