Bug 188492

Summary:

[LFC][Floating] Add basic clearance support

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description zalan 2018-08-12 15:37:17 PDT

ssia

Comment 1 zalan 2018-08-12 16:25:12 PDT

Created attachment 346991 [details]
Patch

Comment 2 Antti Koivisto 2018-08-13 07:28:54 PDT

Comment on attachment 346991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346991&action=review

> Source/WebCore/layout/FloatingState.h:87
> +    enum class FloatStack { Left, Right, Both };

Maybe call this something else than "stack"? It sounds like a data structure.

Comment 3 Antti Koivisto 2018-08-13 07:30:01 PDT

https://www.youtube.com/watch?v=MQ9iPTu_FMA

Comment 4 zalan 2018-08-13 07:48:17 PDT

Committed r234800: <https://trac.webkit.org/changeset/234800>

Comment 5 Radar WebKit Bug Importer 2018-08-13 07:49:20 PDT

<rdar://problem/43232348>