| Summary: | Add ability to ignore process prewarming for launch time benchmark | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Richards <benton_richards> | ||||
| Component: | New Bugs | Assignee: | Ben Richards <benton_richards> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benton_richards, cdumez, commit-queue, ews-feeder, ews-watchlist, ggaren, rniwa, tsavell, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ben Richards
2018-08-09 17:48:57 PDT
Created attachment 346883 [details]
Patch
Comment on attachment 346883 [details] Patch Clearing flags on attachment: 346883 Committed r234750: <https://trac.webkit.org/changeset/234750> All reviewed patches have been landed. Closing bug. Reverted r234750 for reason: Caused 185 perf test failures. Committed r234757: <https://trac.webkit.org/changeset/234757> (In reply to Truitt Savell from comment #5) > Reverted r234750 for reason: > > Caused 185 perf test failures. > > Committed r234757: <https://trac.webkit.org/changeset/234757> I apologize, I was wrong with this rollout. No worries. Can we reland this? yes we should land it again Comment on attachment 346883 [details] Patch Rejecting attachment 346883 [details] from commit-queue. benton_richards@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 346883 [details] Patch Rejecting attachment 346883 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 346883, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in PerformanceTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/8820578 Comment on attachment 346883 [details] Patch Clearing flags on attachment: 346883 Committed r234764: <https://trac.webkit.org/changeset/234764> All reviewed patches have been landed. Closing bug. |