| Summary: | [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Component: | Tools / Tests | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aestes, bdakin, commit-queue, lforschler, megan_gardner, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Wenson Hsieh
2018-08-09 08:09:11 PDT
Created attachment 346836 [details]
Patch
Created attachment 346837 [details]
Fix macOS builds
DragAndDropSimulator seems like it would be a better rename than just DraggingSimulator, since we are simulating both dragging and dropping. (In reply to Megan Gardner from comment #3) > DragAndDropSimulator seems like it would be a better rename than just > DraggingSimulator, since we are simulating both dragging and dropping. I considered this, but went with DraggingSimulator because it sounded more pleasant. But I don't have strong opinions either way — I'll go with DragAndDropSimulator. Created attachment 346838 [details]
Rename to DragAndDropSimulator
r=me unofficial Comment on attachment 346838 [details]
Rename to DragAndDropSimulator
rs=me
Created attachment 346849 [details]
Patch for landing
Comment on attachment 346849 [details] Patch for landing Clearing flags on attachment: 346849 Committed r234731: <https://trac.webkit.org/changeset/234731> |