| Summary: | [MiniBrowser][Win] Allow selection of recent user agents | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
| Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, Hironori.Fujii, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Olmstead
2018-08-06 20:02:38 PDT
Created attachment 346677 [details]
Patch
Updates to the latest released versions. Adds Edge. Moves the setting through the menu to the common base class.
Attachment 346677 [details] did not pass style-queue:
ERROR: Tools/MiniBrowser/win/MiniBrowserLibResource.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Tools/ChangeLog:8: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: spoof, spoof [changelog/unwantedsecurityterms] [3]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 5 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346678 [details]
Patch
Attachment 346678 [details] did not pass style-queue:
ERROR: Tools/MiniBrowser/win/MiniBrowserLibResource.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Tools/ChangeLog:8: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: spoof, spoof [changelog/unwantedsecurityterms] [3]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 4 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 346678 [details] Patch Clearing flags on attachment: 346678 Committed r234650: <https://trac.webkit.org/changeset/234650> All reviewed patches have been landed. Closing bug. |