Bug 188354

Summary:

Make RenderObject noncopyable

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

cdumez

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review-

Description Alex Christensen 2018-08-06 13:31:32 PDT

Make RenderObject noncopyable

Comment 1 Alex Christensen 2018-08-06 13:31:53 PDT

Created attachment 346649 [details]
Patch

Comment 2 Chris Dumez 2018-08-07 16:06:53 PDT

Comment on attachment 346649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346649&action=review

> Source/WebCore/rendering/RenderObject.h:107
> +    WTF_MAKE_NONCOPYABLE(RenderObject);

It is already uncopyable given this data member:
Node& m_node;

Comment 3 Chris Dumez 2018-08-07 16:15:00 PDT

Comment on attachment 346649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346649&action=review

>> Source/WebCore/rendering/RenderObject.h:107
>> +    WTF_MAKE_NONCOPYABLE(RenderObject);
> 
> It is already uncopyable given this data member:
> Node& m_node;

See following review comment by Darin:
https://bugs.webkit.org/show_bug.cgi?id=158111#c45