| Summary: | [LFC][Floating] Revert back to only one list for the all the floatings. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2018-08-01 12:35:02 PDT
Created attachment 346289 [details]
Patch
Created attachment 346293 [details]
Patch
Comment on attachment 346293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346293&action=review > Source/WebCore/layout/FloatingState.h:64 > + FloatingList m_floatings; Is "floatings" a spec term or something? To me "floats" sounds better. (In reply to Antti Koivisto from comment #3) > Comment on attachment 346293 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346293&action=review > > > Source/WebCore/layout/FloatingState.h:64 > > + FloatingList m_floatings; > > Is "floatings" a spec term or something? To me "floats" sounds better. spec calls floats in many ways: "The most interesting characteristic of a float (or "floated" or "floating" box).." I actually prefer "floats" too. AFAIR the only reason why I picked floating was not to confuse it with the primitive type, but I guess it's really hard to confuse them in this context. I'll rename them in a separate patch. Committed r234481: <https://trac.webkit.org/changeset/234481> |