Bug 188181

Summary:

Don't call RenderTheme::platformColorsDidChange() during printing

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Printing

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, ews-watchlist, joepeck, rniwa, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Patch	none

Description Timothy Hatcher 2018-07-30 14:55:54 PDT

We don't need to call RenderTheme::platformColorsDidChange() during printing anymore. RenderTheme caches dark and light mode colors separately. Also platformColorsDidChange() calls Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment() which is very heavy handed and can mess up printing operations.

rdar://problem/42360070

Comment 1 Timothy Hatcher 2018-07-30 15:00:18 PDT Comment hidden (obsolete)

Created attachment 346106 [details]
Patch

Comment 2 EWS Watchlist 2018-07-30 16:05:31 PDT Comment hidden (obsolete)

Comment on attachment 346106 [details]
Patch

Attachment 346106 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8703917

New failing tests:
inspector/page/media-query-list-listener-exception.html

Comment 3 EWS Watchlist 2018-07-30 16:05:33 PDT Comment hidden (obsolete)

Created attachment 346117 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 4 EWS Watchlist 2018-07-30 16:13:34 PDT Comment hidden (obsolete)

Comment on attachment 346106 [details]
Patch

Attachment 346106 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8703930

New failing tests:
inspector/page/media-query-list-listener-exception.html

Comment 5 EWS Watchlist 2018-07-30 16:13:36 PDT Comment hidden (obsolete)

Created attachment 346120 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 6 EWS Watchlist 2018-07-30 16:44:25 PDT Comment hidden (obsolete)

Comment on attachment 346106 [details]
Patch

Attachment 346106 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8704032

New failing tests:
inspector/page/media-query-list-listener-exception.html

Comment 7 EWS Watchlist 2018-07-30 16:44:26 PDT Comment hidden (obsolete)

Created attachment 346125 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 8 Timothy Hatcher 2018-07-30 17:35:25 PDT

Created attachment 346130 [details]
Patch

Comment 9 WebKit Commit Bot 2018-07-31 11:23:44 PDT

Comment on attachment 346130 [details]
Patch

Clearing flags on attachment: 346130

Committed r234432: <https://trac.webkit.org/changeset/234432>

Comment 10 WebKit Commit Bot 2018-07-31 11:23:46 PDT

All reviewed patches have been landed.  Closing bug.