| Summary: | Web Inspector: Dark Mode: disabled breakpoints banner is too light | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, inspector-bugzilla-changes, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 346237 [details] Patch Use the same styles as in Bug 187792 - Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message. Created attachment 346238 [details]
[Image] With patch applied
Comment on attachment 346237 [details] Patch Attachment 346237 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8720731 New failing tests: imported/blink/transitions/unprefixed-transform.html Created attachment 346263 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 346237 [details]
Patch
r=me, looks great!
Comment on attachment 346237 [details] Patch Clearing flags on attachment: 346237 Committed r234464: <https://trac.webkit.org/changeset/234464> All reviewed patches have been landed. Closing bug. |
Created attachment 345941 [details] [Image] disabled breakpoints banner Summary: Disabled breakpoints banner is too light. The banner is shown whenever breakpoints are disabled from the Debugger sidebar panel.