| Summary: | Web Inspector: Dark Mode: highlighted search results are too light | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
The native *unfocused* text selection color is a light gray. It shines through the search highlight background. Perhaps the least invasive solution would be to make the search highlight text color dark. (Wouldn't it be nice to read system colors and pick black/white text color accordingly? Maybe one day.) (In reply to Nikita Vasilyev from comment #2) > The native *unfocused* text selection color is a light gray. [...] I was wrong. It was CodeMirror's color. *** This bug has been marked as a duplicate of bug 190542 *** |
Created attachment 345934 [details] [Image] TextEditor search results Summary: Highlighted search results are too light. From SearchHighlightingDefaultTheme.css:93: .supports-find-banner.showing-find-banner.syntax-highlighted .search-result, .supports-find-banner.showing-find-banner .syntax-highlighted .search-result { background-color: hsla(53, 83%, 53%, 0.2); border-bottom: 1px solid hsl(47, 82%, 60%); } See attached screenshot: - The search-result background-color property uses opacity, which is hard to see against the dark background. - The search-result color is pricking up dark mode's lighter --text-color as well.