| Summary: | arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided type array. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | fpizlo, keith_miller, king_pirate11, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2018-07-26 11:16:33 PDT
Created attachment 345853 [details]
proposed patch.
Comment on attachment 345853 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345853&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1307 > +template<typename T, bool isDouble = std::is_same<T, double>::value> why do you need isDouble? > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1308 > +void copyElements(T* buffer, unsigned offset, void* source, unsigned sourceSize, IndexingType sourceType) ALWAYS_INLINE? Comment on attachment 345853 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345853&action=review >> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1307 >> +template<typename T, bool isDouble = std::is_same<T, double>::value> > > why do you need isDouble? Oops ... old code that is now solved by a superior method. Will delete this. >> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1308 >> +void copyElements(T* buffer, unsigned offset, void* source, unsigned sourceSize, IndexingType sourceType) > > ALWAYS_INLINE? OK. Created attachment 345854 [details]
patch for landing.
Thanks for the review. Landed in r234269: <http://trac.webkit.org/r234269>. |