| Summary: | Reduce unnecessary copying of EditingStyles on ApplyStyleCommand construction | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | darin, ews-watchlist | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2018-07-26 10:17:07 PDT
Created attachment 345850 [details]
Patch
Comment on attachment 345850 [details] Patch Attachment 345850 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8664982 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 345869 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 345850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345850&action=review > Source/WebCore/ChangeLog:28 > + * editing/EditorCommand.cpp: > + (WebCore::executeMakeTextWritingDirectionLeftToRight): > + (WebCore::executeMakeTextWritingDirectionNatural): > + (WebCore::executeMakeTextWritingDirectionRightToLeft): This is a not-particularly-closely-related (minor) refactoring, not mentioned in the change log. (In reply to Darin Adler from comment #4) > Comment on attachment 345850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345850&action=review > > > Source/WebCore/ChangeLog:28 > > + * editing/EditorCommand.cpp: > > + (WebCore::executeMakeTextWritingDirectionLeftToRight): > > + (WebCore::executeMakeTextWritingDirectionNatural): > > + (WebCore::executeMakeTextWritingDirectionRightToLeft): > > This is a not-particularly-closely-related (minor) refactoring, not > mentioned in the change log. Yeah, I'm going to beef up the changelog before landing. |