Bug 188062

Summary: Reduce unnecessary copying of EditingStyles on ApplyStyleCommand construction
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: NEW    
Severity: Normal CC: darin, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews205 for win-future none

Sam Weinig
Reported 2018-07-26 10:17:07 PDT
Reduce unnecessary copying of EditingStyles on ApplyStyleCommand construction
Attachments
Patch (21.76 KB, patch)
2018-07-26 10:20 PDT, Sam Weinig 		darin: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.90 MB, application/zip)
2018-07-26 14:10 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2018-07-26 10:20:18 PDT
Created attachment 345850 [details] Patch
EWS Watchlist
Comment 2 2018-07-26 14:10:02 PDT
Comment on attachment 345850 [details] Patch Attachment 345850 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8664982 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 3 2018-07-26 14:10:14 PDT
Created attachment 345869 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Darin Adler
Comment 4 2018-07-26 23:27:42 PDT
Comment on attachment 345850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345850&action=review > Source/WebCore/ChangeLog:28 > + * editing/EditorCommand.cpp: > + (WebCore::executeMakeTextWritingDirectionLeftToRight): > + (WebCore::executeMakeTextWritingDirectionNatural): > + (WebCore::executeMakeTextWritingDirectionRightToLeft): This is a not-particularly-closely-related (minor) refactoring, not mentioned in the change log.
Sam Weinig
Comment 5 2018-07-27 10:02:48 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 345850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345850&action=review > > > Source/WebCore/ChangeLog:28 > > + * editing/EditorCommand.cpp: > > + (WebCore::executeMakeTextWritingDirectionLeftToRight): > > + (WebCore::executeMakeTextWritingDirectionNatural): > > + (WebCore::executeMakeTextWritingDirectionRightToLeft): > > This is a not-particularly-closely-related (minor) refactoring, not > mentioned in the change log. Yeah, I'm going to beef up the changelog before landing.
Note You need to log in before you can comment on or make changes to this bug.