Bug 187793

Summary: Hitting RELEASE_ASSERT(!m_activeDOMObjectAdditionForbidden) under HTMLMediaElement::resume()
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, jer.noble, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Antoine Quint 2018-07-18 17:27:53 PDT 
HTMLMediaElement::resume() may end up calling prepareForLoad() which will end up calling configureMediaControls() which will in turn instantiate the media controls and run JS code, which will trigger RELEASE_ASSERT(!m_activeDOMObjectAdditionForbidden) in ScriptExecutionContext::didCreateActiveDOMObject(). We need to delay the call to prepareForLoad() in resume().
Comment 1 Antoine Quint 2018-07-18 17:28:03 PDT 
<rdar://problem/42308469>
Comment 2 Antoine Quint 2018-07-18 17:32:12 PDT 
Created attachment 345312 [details]
Patch
Comment 3 Chris Dumez 2018-07-18 18:18:06 PDT 
Comment on attachment 345312 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-07-19 06:38:22 PDT 
Comment on attachment 345312 [details]
Patch

Clearing flags on attachment: 345312

Committed r233982: <https://trac.webkit.org/changeset/233982>
Comment 5 WebKit Commit Bot 2018-07-19 06:38:24 PDT 
All reviewed patches have been landed.  Closing bug.