Bug 187709

Summary: [JSC] UnlinkedCodeBlock::shrinkToFit miss m_constantIdentifierSets
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2018-07-16 13:02:10 PDT
[JSC] UnlinkedCodeBlock::shrinkToFit miss m_constantIdentifierSets
Comment 1 Yusuke Suzuki 2018-07-16 13:02:33 PDT
Created attachment 345115 [details]
Patch
Comment 2 Yusuke Suzuki 2018-07-16 13:03:34 PDT
Comment on attachment 345115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345115&action=review

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:392
>      m_expressionInfo.shrinkToFit();

Aligned the order to member definitions.
Comment 3 Mark Lam 2018-07-16 13:07:29 PDT
Comment on attachment 345115 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2018-07-16 13:10:12 PDT
Committed r233862: <https://trac.webkit.org/changeset/233862>
Comment 5 Radar WebKit Bug Importer 2018-07-16 13:13:41 PDT
<rdar://problem/42252940>