Bug 187690

Summary: [iOS apps on macOS] Playing embedded Twitter videos in the News app crashes the web process
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, commit-queue, eric.carlson, jer.noble, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
ChangeLog tweak none

Description Wenson Hsieh 2018-07-15 19:27:27 PDT 
<rdar://problem/41869703>
Comment 1 Wenson Hsieh 2018-07-15 19:52:04 PDT 
Created attachment 345073 [details]
Patch
Comment 2 Wenson Hsieh 2018-07-15 20:15:04 PDT 
Created attachment 345075 [details]
ChangeLog tweak
Comment 3 Tim Horton 2018-07-15 21:51:46 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

Ha! This makes so much sense.
Comment 4 Wenson Hsieh 2018-07-15 21:53:03 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

Thanks for the review!
Comment 5 WebKit Commit Bot 2018-07-15 22:19:49 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

Clearing flags on attachment: 345075

Committed r233841: <https://trac.webkit.org/changeset/233841>
Comment 6 WebKit Commit Bot 2018-07-15 22:19:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2018-07-17 15:46:01 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

View in context: https://bugs.webkit.org/attachment.cgi?id=345075&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:97
> +#if PLATFORM(IOSMAC)

Why does the same issue not impact other configurations? It seems fragile that the only do the safe thing on IOSMAC.
Comment 8 Wenson Hsieh 2018-07-17 15:48:24 PDT 
(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 345075 [details]
> ChangeLog tweak
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345075&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:97
> > +#if PLATFORM(IOSMAC)
> 
> Why does the same issue not impact other configurations? It seems fragile
> that the only do the safe thing on IOSMAC.

It doesn't impact macOS because we don't need to dynamically load iOS-only symbols there.

In this case (on iosmac), we were failing to link symbols in AudioSessionIOS, which is not compiled on macOS.