Bug 187634

Summary:

Signal.cpp's activeThreads() should only create its ThreadGroup once.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	none

Description Mark Lam 2018-07-12 22:34:07 PDT

registerThreadForMachExceptionHandling() is relying on the activeThreads() ThreadGroup being a singleton.

<rdar://problem/40662311>

Comment 1 Mark Lam 2018-07-12 22:40:12 PDT

Created attachment 344926 [details]
proposed patch.

Comment 2 Yusuke Suzuki 2018-07-12 22:50:31 PDT

Comment on attachment 344926 [details]
proposed patch.

r=me

Comment 3 Mark Lam 2018-07-12 23:37:11 PDT

Comment on attachment 344926 [details]
proposed patch.

Thanks for the review.  Landing now.

Comment 4 WebKit Commit Bot 2018-07-13 00:04:17 PDT

Comment on attachment 344926 [details]
proposed patch.

Clearing flags on attachment: 344926

Committed r233795: <https://trac.webkit.org/changeset/233795>

Comment 5 WebKit Commit Bot 2018-07-13 00:04:19 PDT

All reviewed patches have been landed.  Closing bug.