| Summary: | Make WebKit.LinkColorWithSystemAppearance work across system versions | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||
| Component: | Tools / Tests | Assignee: | Timothy Hatcher <timothy> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, lforschler, realdawei, ryanhaddad, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Timothy Hatcher
2018-07-11 17:51:39 PDT
Created attachment 344800 [details]
Patch
Comment on attachment 344800 [details]
Patch
I might be missing something here, but it looks like +[NSColor linkColor] only exists in <AppKit/NSColor.h> on macOS Mojave (despite NS_AVAILABLE_MAC(10_10) in the header).
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 344800 [details] > Patch > > I might be missing something here, but it looks like +[NSColor linkColor] > only exists in <AppKit/NSColor.h> on macOS Mojave (despite > NS_AVAILABLE_MAC(10_10) in the header). Ah, that being said, +[NSColor linkColor] is SPI in NSColor_Private.h on Sierra and High Sierra SDKs, where its availability is declared as NS_AVAILABLE_MAC(10_10). I'm not sure if transferring the same availability over to the public header was an intentional change in Mojave...but it seems like we need to forward declare this to get it to build on the open source WebKit bots. Sigh, yep. We declare it in our NSColorSPI.h. I’ll just include that. Created attachment 344858 [details]
Patch
Created attachment 344861 [details]
Patch
Comment on attachment 344861 [details] Patch Clearing flags on attachment: 344861 Committed r233775: <https://trac.webkit.org/changeset/233775> All reviewed patches have been landed. Closing bug. |