| Summary: | [JSC] Thread VM& to JSCell::methodTable(VM&) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2018-07-10 22:27:51 PDT
Created attachment 344752 [details]
Patch
Created attachment 344753 [details]
Patch
Created attachment 344756 [details]
Patch
Comment on attachment 344756 [details]
Patch
nit: in all the functions, can you put VM& as the first argument instead of the last? Thanks.
(In reply to Mark Lam from comment #4) > Comment on attachment 344756 [details] > Patch > > nit: in all the functions, can you put VM& as the first argument instead of > the last? Thanks. These functions are a method in ClassInfo's MethodTable. So the first argument is used for the `thisObject` cell. In our convention, we define arguments in the following order for MethodTable's method. JSCell* thisObject, ExecState*, VM&, arguments... So, in this case, I think `JSCell*, VM&` order is OK. Committed r233765: <https://trac.webkit.org/changeset/233765> |