Bug 187548

Summary: [JSC] Thread VM& to JSCell::methodTable(VM&)
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2018-07-10 22:27:51 PDT
[JSC] Thread VM& to JSCell::methodTable(VM&)
Attachments
Patch (42.50 KB, patch)
2018-07-10 22:29 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (42.47 KB, patch)
2018-07-10 22:30 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (42.48 KB, patch)
2018-07-10 22:55 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-10 22:29:15 PDT
Created attachment 344752 [details] Patch
Yusuke Suzuki
Comment 2 2018-07-10 22:30:03 PDT
Created attachment 344753 [details] Patch
Yusuke Suzuki
Comment 3 2018-07-10 22:55:15 PDT
Created attachment 344756 [details] Patch
Mark Lam
Comment 4 2018-07-11 09:30:22 PDT
Comment on attachment 344756 [details] Patch nit: in all the functions, can you put VM& as the first argument instead of the last? Thanks.
Yusuke Suzuki
Comment 5 2018-07-12 01:37:44 PDT
(In reply to Mark Lam from comment #4) > Comment on attachment 344756 [details] > Patch > > nit: in all the functions, can you put VM& as the first argument instead of > the last? Thanks. These functions are a method in ClassInfo's MethodTable. So the first argument is used for the `thisObject` cell. In our convention, we define arguments in the following order for MethodTable's method. JSCell* thisObject, ExecState*, VM&, arguments... So, in this case, I think `JSCell*, VM&` order is OK.
Yusuke Suzuki
Comment 6 2018-07-12 01:43:50 PDT
Committed r233765: <https://trac.webkit.org/changeset/233765>
Radar WebKit Bug Importer
Comment 7 2018-07-12 01:44:18 PDT
<rdar://problem/42110538>
Note You need to log in before you can comment on or make changes to this bug.