Bug 187466

Summary: Avoid caching HLS 200 responses
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ahmad.saleem792, beidson, cdumez, cgarcia, eric.carlson, ews-watchlist, ggaren, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
eric.carlson: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews204 for win-future none

Description Antti Koivisto 2018-07-09 05:00:24 PDT
We don't want to cache streaming media even when it is marked cacheable to avoid churn. Currently some HLS streams may get cached.
Comment 1 Antti Koivisto 2018-07-09 05:01:01 PDT
<rdar://problem/41910128>
Comment 2 Antti Koivisto 2018-07-09 05:15:00 PDT
Created attachment 344578 [details]
patch

Will try to make a test.
Comment 3 EWS Watchlist 2018-07-09 06:53:04 PDT
Comment on attachment 344578 [details]
patch

Attachment 344578 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8481948

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 4 EWS Watchlist 2018-07-09 06:53:15 PDT
Created attachment 344581 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Ahmad Saleem 2022-10-10 10:05:46 PDT
In this commit we disabled caching altogether for HLS:

https://github.com/WebKit/WebKit/commit/6f1aa1431a1df070526c2918a2332c6d53322ed1#diff-3e6ec4e4ac82410cffa7edc087fe8d45dd3babc8e8d164172e64f8ec3d5d6885

Do we need this anymore? Thanks!