| Summary: | Returning PiP'd video to fullscreen while playing leaves video muted. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, ryanhaddad, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2018-06-29 09:05:57 PDT
Created attachment 343915 [details]
Patch
Created attachment 343918 [details]
Patch
Comment on attachment 343918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343918&action=review > LayoutTests/media/picture-in-picture-interruption.html:34 > + <div>This tests that video is in the correct media session state after enting a background interruption while pipped.</div> Nit: "enting" Committed r233360: <https://trac.webkit.org/changeset/233360> media/picture-in-picture-interruption.html is timing out on iOS Simulator bots: https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233374%20(5903)/results.html (In reply to Ryan Haddad from comment #6) > media/picture-in-picture-interruption.html is timing out on iOS Simulator > bots: > > https://build.webkit.org/results/ > Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233374%20(5903)/ > results.html Oh, probably because of: runWithKeyDown(function(){ video.webkitSetPresentationMode('picture-in-picture'); }); Skipped test on iOS in https://trac.webkit.org/r233382. |