Bug 186881

Summary: Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: CSSAssignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, commit-queue: commit-queue-

Description Emilio Cobos Álvarez (:emilio) 2018-06-21 01:41:15 PDT
Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
Comment 1 Emilio Cobos Álvarez (:emilio) 2018-06-21 01:45:55 PDT
Created attachment 343225 [details]
Patch
Comment 2 Antti Koivisto 2018-06-26 14:08:25 PDT
r=me
Comment 3 WebKit Commit Bot 2018-06-27 02:28:34 PDT
Comment on attachment 343225 [details]
Patch

Rejecting attachment 343225 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343225, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=343225&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=186881&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 343225 from bug 186881.
Fetching: https://bugs.webkit.org/attachment.cgi?id=343225
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej
patching file Source/WebCore/style/StyleTreeResolver.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/8356970
Comment 4 Emilio Cobos Álvarez (:emilio) 2018-06-27 02:34:32 PDT
Committed r233251: <https://trac.webkit.org/changeset/233251>
Comment 5 Radar WebKit Bug Importer 2018-06-27 02:37:25 PDT
<rdar://problem/41514587>