| Summary: | svn-apply should handle svn property changes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Roy Reapor <rreapor> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | aakash_jain, ap, lforschler, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=190025 | ||
|
Description
Roy Reapor
2018-06-14 10:19:47 PDT
I’m pretty sure that it always had. What happened? (In reply to Alexey Proskuryakov from comment #2) > I’m pretty sure that it always had. What happened? I found it while investigating why bug 185949 is not Landin. The SVN pre-commit hook works. But I found that svn-apply doesn't handle property modifications. I also found the comment in svn-apply from 2010. $ svn blame svn-apply -v | grep property 57453 dbates@webkit.org 2010-04-11 12:09:29 -0700 (Sun, 11 Apr 2010) # Handle property changes. Correct patches will not be committed correctly if it contains svn property changes. > $ svn blame svn-apply -v | grep property > 57453 dbates@webkit.org 2010-04-11 12:09:29 -0700 (Sun, 11 Apr 2010) # > Handle property changes. Just for future reference, here is svn-apply code mentioning about missing feature to "handle property changes": https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/svn-apply#L52 |