| Summary: | [Mail] Use the Mail Viewer height as the base for resolving vertical viewport units | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | bfulgham, ews-watchlist, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
zalan
2018-06-12 21:24:07 PDT
bug 186585 tracks the horizontal viewport unit resolving for autosized content, but we might want to extend this functionality to the vertical viewport units as well. Created attachment 342629 [details]
Horizontal-only
Created attachment 342630 [details]
Horizontal and vertical
We should also consider overriding the vh as well (for that the enableAutoSize() needs the viewer height too)
Comment on attachment 342629 [details] Horizontal-only Attachment 342629 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8157585 New failing tests: fast/dynamic/noninlinebadness.html fast/dynamic/outerHTML-img.html fast/dynamic/outerHTML-doc.html js/dom/JSON-stringify.html Created attachment 342638 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 342629 [details] Horizontal-only Attachment 342629 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/8157581 New failing tests: fast/dynamic/mail-autosize-viewport-unit.html Created attachment 342640 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
(In reply to Build Bot from comment #4) > Comment on attachment 342629 [details] > Horizontal-only > > Attachment 342629 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/8157585 > > New failing tests: > fast/dynamic/noninlinebadness.html > fast/dynamic/outerHTML-img.html > fast/dynamic/outerHTML-doc.html > js/dom/JSON-stringify.html It looks like we leak the autosize state to subsequent tests. (In reply to Build Bot from comment #6) > Comment on attachment 342629 [details] > Horizontal-only > > Attachment 342629 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/8157581 > > New failing tests: > fast/dynamic/mail-autosize-viewport-unit.html We don't autosize in iOS? (In reply to zalan from comment #9) > (In reply to Build Bot from comment #6) > > Comment on attachment 342629 [details] > > Horizontal-only > > > > Attachment 342629 [details] did not pass ios-sim-ews (ios-simulator-wk2): > > Output: http://webkit-queues.webkit.org/results/8157581 > > > > New failing tests: > > fast/dynamic/mail-autosize-viewport-unit.html > We don't autosize in iOS? Wenson and I had a quick chat about this and we concluded that the viewport configuration probably interferes with autosizing on iOS. I don't actually need to test this on iOS. Will just skip it. Comment on attachment 342629 [details] Horizontal-only Attachment 342629 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8168748 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 342702 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
|