| Summary: | CFGSimplificationPhase should de-dupe jettisonedBlocks | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, realdawei, rmorisset, ryanhaddad, ticaiolima, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2018-06-12 19:12:33 PDT
This should fix the crash on this test: js/dom/JSON-stringify.html introduced by https://trac.webkit.org/changeset/232741/webkit Created attachment 342622 [details]
patch
I'm in the middle of building, so I still need to test this, but I'm pretty sure it's the correct fix.
Comment on attachment 342622 [details]
patch
I've confirmed this fixes the crash.
LGTM, but I'm not an official reviewer. Pinging reviewers. We need the fix ASAP as this is affecting EWS. Comment on attachment 342622 [details] patch Clearing flags on attachment: 342622 Committed r232800: <https://trac.webkit.org/changeset/232800> All reviewed patches have been landed. Closing bug. I think ARES-6 is still crashing. https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6 (In reply to Yusuke Suzuki from comment #9) > I think ARES-6 is still crashing. > https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6 Michael is working on a fix (In reply to Saam Barati from comment #10) > (In reply to Yusuke Suzuki from comment #9) > > I think ARES-6 is still crashing. > > https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6 > > Michael is working on a fix Nice! |