Bug 186498

Summary: [Web Animations] Make WPT test at interfaces/DocumentTimeline/constructor.html pass reliably
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186509
Attachments:
Description Flags
Patch
dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews206 for win-future none

Description Antoine Quint 2018-06-11 04:38:48 PDT
The WPT test at imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/constructor.html is failing reliably, flaky or timing out.
Comment 1 Radar WebKit Bug Importer 2018-06-11 04:38:59 PDT
<rdar://problem/41000205>
Comment 2 Antoine Quint 2018-07-09 13:56:16 PDT
Created attachment 344610 [details]
Patch
Comment 3 Dean Jackson 2018-07-09 14:15:16 PDT
Comment on attachment 344610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344610&action=review

> Source/WebCore/animation/DocumentTimeline.idl:29
> +    ConstructorCallWith=Document,

How come this wasn't needed before? How did you create a DocumentTimeline?
Comment 4 Antoine Quint 2018-07-09 14:54:34 PDT
(In reply to Dean Jackson from comment #3)
> Comment on attachment 344610 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344610&action=review
> 
> > Source/WebCore/animation/DocumentTimeline.idl:29
> > +    ConstructorCallWith=Document,
> 
> How come this wasn't needed before? How did you create a DocumentTimeline?

You didn't, the Document would create one for you and you'd access it via `document.timeline`.
Comment 5 EWS Watchlist 2018-07-09 15:33:16 PDT
Comment on attachment 344610 [details]
Patch

Attachment 344610 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8485968

New failing tests:
http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html
http/tests/preload/onload_event.html
Comment 6 EWS Watchlist 2018-07-09 15:33:27 PDT
Created attachment 344631 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Antoine Quint 2018-07-09 16:53:02 PDT
Committed r233667: <https://trac.webkit.org/changeset/233667>