Bug 111636
| Summary: | RenderFullScreen should call setNeedsLayoutAndPrefWidthsRecalc on the child (?) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Christian Biesinger <cbiesinger> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | fred.wang, hyatt, jer.noble |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
Christian Biesinger
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFullScreen.cpp?rev=HEAD#L154
The code here looks like:
154 while ((child = firstChild())) {
155 child->remove();
156 parent()->addChild(child, this);
157 parent()->setNeedsLayoutAndPrefWidthsRecalc();
158 }
It seems to me like setNeedsLayoutAndPrefWidthsRecalc() should be called on the child (which then would recurse through the parents).
hyatt, does that seem plausible? At least, if it is right to call it on the parent, it should be outside the loop.
(I don't have a testcase either way, we found this by code inspection)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang Nélar
RenderFullScreen was removed in https://commits.webkit.org/255641@main
*** This bug has been marked as a duplicate of bug 246065 ***