Attachment 335112 Details for Bug 183374 – Patch

[patch] Patch

bug-183374-20180306132859.patch (text/plain), 3.14 KB, created by Danyao Wang on 2018-03-06 10:29:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Danyao Wang

Created: 2018-03-06 10:29:00 PST

Size: 3.14 KB

patch

obsolete

>Subversion Revision: 229289
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4c165db40c367e51af4c2cb6aec7f7b9b4d6f69e..2716ae02b7e31c49c17cfcfe5a06a273d347e1b0 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-03-06  Danyao Wang  <danyao@chromium.org>
>+
>+        LayoutTests/http/tests/misc/window-dot-stop.html fails with async policy delegate
>+        https://bugs.webkit.org/show_bug.cgi?id=183374
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This test expects to see a slow load in an iframe started but then canceled due to
>+        window.stop(). With async decide policy, the cancelation happens before
>+        continueLoadAfterNavigationPolicy() and DocumentLoader::willSendRequest is never called.
>+        Instead, we can use the absence of onload callbacks to make sure that window.stop()
>+        works as intended.
>+
>+        Add a version of the test that forces async decide policy.
>+
>+        * http/tests/misc/window-dot-stop-async-policy-expected.txt: Added.
>+        * http/tests/misc/window-dot-stop-async-policy.html: Added.
>+
> 2018-03-05  Ali Juma  <ajuma@chromium.org>
> 
>         imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html times out with async policy delegates
>diff --git a/LayoutTests/http/tests/misc/window-dot-stop-async-policy-expected.txt b/LayoutTests/http/tests/misc/window-dot-stop-async-policy-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..b0b0090561cc1c54bafff022cce77886c727f904
>--- /dev/null
>+++ b/LayoutTests/http/tests/misc/window-dot-stop-async-policy-expected.txt
>@@ -0,0 +1,4 @@
>+http://127.0.0.1:8000/misc/window-dot-stop-async-policy.html - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999, failing URL "http://127.0.0.1:8000/misc/window-dot-stop-async-policy.html">
>+This tests for the successful use of window.stop()
>+
>+
>diff --git a/LayoutTests/http/tests/misc/window-dot-stop-async-policy.html b/LayoutTests/http/tests/misc/window-dot-stop-async-policy.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..7cff65ab11e40b8985a9258a9306a68045326c92
>--- /dev/null
>+++ b/LayoutTests/http/tests/misc/window-dot-stop-async-policy.html
>@@ -0,0 +1,28 @@
>+<html>
>+<script>
>+    if (window.testRunner) {
>+        if (testRunner.setShouldDecideNavigationPolicyAfterDelay)
>+          testRunner.setShouldDecideNavigationPolicyAfterDelay(true);
>+
>+        testRunner.dumpResourceLoadCallbacks();
>+        testRunner.waitUntilDone();
>+    }
>+
>+    function testFailed(label) {
>+      console.log("TEST FAILED: If window.stop(), " + label + " should not have fired.");
>+    }
>+</script>
>+<body onload="testFailed('body.onload')">
>+This tests for the successful use of window.stop()<br>
>+<iframe src="http://127.0.0.1:8000/incremental/slow-utf8-text.pl" onload="testFailed('iframe.onload')">
>+</iframe><br>
>+<script>
>+if (window.testRunner) {
>+    testRunner.dumpAsText();
>+    setTimeout("testRunner.notifyDone()", 0);
>+}
>+window.stop();
>+</script>
>+TEST FAILED:  If window.stop() works, you shouldn't be able to see this and the above iframe should not have loaded.
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 183374: 335112 | 335113