187845 – Always remove fill-forwards animations from GraphicsLayers in the web animations code path

Bug 187845 - Always remove fill-forwards animations from GraphicsLayers in the web animations code path

Summary: Always remove fill-forwards animations from GraphicsLayers in the web animati...

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Fraser (smfr) 2018-07-19 20:03:45 PDT

The fix for bug 187844 needs implementing for the Web Animation code path too.

Comment 1 Radar WebKit Bug Importer 2018-07-30 19:11:13 PDT

<rdar://problem/42756351>

Comment 2 Antoine Quint 2018-09-26 06:13:04 PDT

*** Bug 189598 has been marked as a duplicate of this bug. ***

Comment 3 Antoine Quint 2018-09-27 05:21:21 PDT

So the test behaves as expected with the new engine, there is some flakiness on macOS though, as pointed out by webkit.org/b/189598.

Comment 4 Antoine Quint 2018-09-27 05:40:11 PDT

I think the test only passes because of how it's written. I think if the animation hasn't actually started yet the test passes.

Comment 5 Antoine Quint 2018-09-27 05:42:06 PDT

Something is off about that test, if I make the animation longer, it fails with the old engine as well.

Comment 6 Antoine Quint 2019-11-14 10:38:14 PST

Forward-duping this to https://bugs.webkit.org/show_bug.cgi?id=204198.

*** This bug has been marked as a duplicate of bug 204198 ***