Bug 98547

Summary: Clipboard::types() should return an ordered collection.
Product: WebKit Reporter: Andreas Kling <kling>
Component: UI EventsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, gyuyoung.kim, haraken, japhet, mifenton, peter+ews, rafael.lobo, rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch?
peter+ews: commit-queue-
Patch?? none

Andreas Kling
Reported 2012-10-05 12:29:56 PDT
Since we expose Clipboard::types() to the web, we should handle it using an ordered collection internally. When lowering the default minimum table size for WTF hash tables, some web-exposed string arrays got reordered because the HashSet<String> returned by Clipboard::types() got reordered in rehash.
Attachments
Patch? (18.37 KB, patch)
2012-10-05 12:40 PDT, Andreas Kling 		peter+ews: commit-queue-
DetailsFormatted DiffDiff
Patch?? (18.59 KB, patch)
2012-10-05 13:21 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-10-05 12:40:29 PDT
Created attachment 167368 [details] Patch?
Peter Beverloo (cr-android ews)
Comment 2 2012-10-05 13:02:37 PDT
Comment on attachment 167368 [details] Patch? Attachment 167368 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14179576
WebKit Review Bot
Comment 3 2012-10-05 13:09:11 PDT
Comment on attachment 167368 [details] Patch? Attachment 167368 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14179582
Andreas Kling
Comment 4 2012-10-05 13:21:32 PDT
Created attachment 167372 [details] Patch??
Rafael Brandao
Comment 5 2012-10-05 15:20:47 PDT
Awesome patch! Incredible how we ever returned them ordered by insertion. :-)
Darin Adler
Comment 6 2012-10-05 18:12:43 PDT
Comment on attachment 167372 [details] Patch?? Why not Vector<String>? I can’t imagine that the types vector ever gets so long that the hash table is an important optimization.
WebKit Review Bot
Comment 7 2012-10-06 12:14:05 PDT
Comment on attachment 167372 [details] Patch?? Clearing flags on attachment: 167372 Committed r130588: <http://trac.webkit.org/changeset/130588>
WebKit Review Bot
Comment 8 2012-10-06 12:14:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.