Bug 98231

Summary: [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: alexander.shalamov, d-r, gyuyoung.kim, hausmann, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98162, 98341, 98389    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2012-10-02 22:38:36 PDT
We should start using X11 in EFL's DumpRenderTree now that we are using XvfbDriver for the layout tests.
Attachments
Patch (1.75 KB, patch)
2012-10-02 23:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2012-10-02 23:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.25 KB, patch)
2012-10-02 23:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-02 23:13:59 PDT
Created attachment 166810 [details] Patch
Chris Dumez
Comment 2 2012-10-02 23:25:38 PDT
Comment on attachment 166810 [details] Patch Needs the same in WKTR.
Chris Dumez
Comment 3 2012-10-02 23:30:07 PDT
Created attachment 166813 [details] Patch Apply same change to WebKitTestRunner.
Chris Dumez
Comment 4 2012-10-02 23:52:01 PDT
Created attachment 166816 [details] Patch Properly initialize ecore_x library in ewk_main.
Alexander Shalamov
Comment 5 2012-10-03 00:43:10 PDT
Comment on attachment 166816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166816&action=review > Source/WebKit/efl/ewk/ewk_main.cpp:101 > + if (!ecore_x_init(0)) { Are those init calls are order dependant? ecore_x_init is not, but I'm just curious how edje and evas objects are initialized. > Source/WebKit/efl/ewk/ewk_main.cpp:116 > + edje_shutdown(); Should it be ecore_x_shutdown() ?
Chris Dumez
Comment 6 2012-10-03 00:48:06 PDT
Comment on attachment 166816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166816&action=review >> Source/WebKit/efl/ewk/ewk_main.cpp:101 >> + if (!ecore_x_init(0)) { > > Are those init calls are order dependant? > ecore_x_init is not, but I'm just curious how edje and evas objects are initialized. I don't believe they are. >> Source/WebKit/efl/ewk/ewk_main.cpp:116 >> + edje_shutdown(); > > Should it be ecore_x_shutdown() ? No, this is correct. We come to this label if ecore_x_init() failed so there is no need to call ecore_x_shutdown(). We however, need to shutdown the previously intialized library (edje). See error_edje: 2 lines below, it calls ecore_evas_shutdown(), not edje_shutdown().
Alexander Shalamov
Comment 7 2012-10-03 00:56:44 PDT
(In reply to comment #6) > (From update of attachment 166816 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166816&action=review > > >> Source/WebKit/efl/ewk/ewk_main.cpp:101 > >> + if (!ecore_x_init(0)) { > > > > Are those init calls are order dependant? > > ecore_x_init is not, but I'm just curious how edje and evas objects are initialized. > > I don't believe they are. > > >> Source/WebKit/efl/ewk/ewk_main.cpp:116 > >> + edje_shutdown(); > > > > Should it be ecore_x_shutdown() ? > > No, this is correct. We come to this label if ecore_x_init() failed so there is no need to call ecore_x_shutdown(). We however, need to shutdown the previously intialized library (edje). See error_edje: 2 lines below, it calls ecore_evas_shutdown(), not edje_shutdown(). LGTM! Thanks.
Raphael Kubo da Costa (:rakuco)
Comment 8 2012-10-03 02:33:20 PDT
Comment on attachment 166816 [details] Patch Alright, looks fine, thanks!
WebKit Review Bot
Comment 9 2012-10-03 22:42:36 PDT
Comment on attachment 166816 [details] Patch Clearing flags on attachment: 166816 Committed r130363: <http://trac.webkit.org/changeset/130363>
WebKit Review Bot
Comment 10 2012-10-03 22:42:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.