Bug 97196

Summary: [Qt] Enable CSS regions by default
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, mihnea, ossy, vestbo
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-09-20 04:35:00 PDT
CSS region is built already, but it is disabled in runtime in qwebsettings.cpp by default. I tested it, almost all tests pass, so it's time to enable it by default. Patch is coming soon.
Attachments
Patch (848.31 KB, patch)
2012-09-20 05:11 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-09-20 04:39:39 PDT
fast/regions/overflow-size-change-with-stacking-context.html - fails fast/regions/css-regions-disabled.html - fails on Qt WK2 failing reftests with minor pixel differences: fast/regions/floats-basic-in-variable-width-regions.html fast/regions/positioned-objects-block-static-spanning-regions-rtl.html fast/regions/region-style-rule-position.html
Csaba Osztrogonác
Comment 2 2012-09-20 05:11:00 PDT
Created attachment 164897 [details] Patch
Csaba Osztrogonác
Comment 3 2012-09-20 05:13:01 PDT
(In reply to comment #1) > fast/regions/overflow-size-change-with-stacking-context.html - fails new bug: https://bugs.webkit.org/show_bug.cgi?id=97199 > fast/regions/css-regions-disabled.html - fails on Qt WK2 new bug: https://bugs.webkit.org/show_bug.cgi?id=97197
Dirk Schulze
Comment 4 2012-09-20 05:44:48 PDT
Comment on attachment 164897 [details] Patch LGTM. r=me
Csaba Osztrogonác
Comment 5 2012-09-20 06:24:38 PDT
Committed r129126: <http://trac.webkit.org/changeset/129126>
Note You need to log in before you can comment on or make changes to this bug.