Bug 94067

Summary: Update test expectations for css3/filters/custom/invalid-custom-filter-shader.html failing on Apple Lion Debug WK1 (Tests)
Product: WebKit Reporter: Kiran Muppala <cmuppala>
Component: Tools / TestsAssignee: Kiran Muppala <cmuppala>
Status: RESOLVED FIXED    
Severity: Normal CC: cmuppala, fmalita, krit, webkit.review.bot
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kiran Muppala
Reported 2012-08-14 21:23:24 PDT
The test css3/filters/custom/invalid-custom-filter-shader.html started failing on Apple Lion Debug WK1 (Tests) between 125459 and 125464. http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125464%20(1839)/css3/filters/custom/invalid-custom-filter-shader-diffs.htm http://trac.webkit.org/log/trunk?rev=125464&stop_rev=125459 This is most likely caused by http://trac.webkit.org/changeset/125462: WebKit+SVG does not support color-interpolation-filters or draw filters in correct colorspace https://bugs.webkit.org/show_bug.cgi?id=6033
Attachments
Patch (1.49 KB, patch)
2012-08-14 21:37 PDT, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Patch (1.67 KB, patch)
2012-08-15 16:18 PDT, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kiran Muppala
Comment 1 2012-08-14 21:37:24 PDT
Created attachment 158498 [details] Patch
Florin Malita
Comment 2 2012-08-15 00:54:27 PDT
The image diff is expected as filters are now applied in a different color space by default, so it should be fine to mark it for rebaseline instead of regression. Quite a few tests need rebaselining (see the BUGWK6033 lines in TestExpectations), but the original patch missed this particular one. Thanks for catching it.
Kiran Muppala
Comment 3 2012-08-15 16:18:10 PDT
Created attachment 158655 [details] Patch
Kiran Muppala
Comment 4 2012-08-15 16:20:29 PDT
Attached patch to add css3/filters/custom/invalid-custom-filter-shader.html to the list of test needing re-baselining after https://bugs.webkit.org/show_bug.cgi?id=6033
WebKit Review Bot
Comment 5 2012-08-15 16:27:09 PDT
Comment on attachment 158655 [details] Patch Rejecting attachment 158655 [details] from commit-queue. cmuppala@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 6 2012-08-15 18:04:10 PDT
Comment on attachment 158655 [details] Patch Clearing flags on attachment: 158655 Committed r125731: <http://trac.webkit.org/changeset/125731>
WebKit Review Bot
Comment 7 2012-08-15 18:04:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.