Bug 93645

Summary: [EFL][WK2] Add Skipped file for EFL WK2
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, naginenis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838, 93353    
Attachments:
Description Flags
patch
kenneth: commit-queue-
patch v2 none

Mikhail Pozdnyakov
Reported 2012-08-09 13:12:55 PDT
EFL WK2 needs a separate Skipped file located at LayoutTests/platform/efl-wk2/Skipped so that it will be possible to keep EFL WK2 bot green.
Attachments
patch (13.01 KB, patch)
2012-08-10 03:24 PDT, Mikhail Pozdnyakov 		kenneth: commit-queue-
DetailsFormatted DiffDiff
patch v2 (13.01 KB, patch)
2012-08-10 04:23 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-08-10 03:24:33 PDT
Created attachment 157697 [details] patch
Kenneth Rohde Christiansen
Comment 2 2012-08-10 04:20:12 PDT
Comment on attachment 157697 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=157697&action=review > LayoutTests/ChangeLog:6 > + Uneviewed gardening. Unreviewed
Mikhail Pozdnyakov
Comment 3 2012-08-10 04:23:38 PDT
Created attachment 157701 [details] patch v2
Mikhail Pozdnyakov
Comment 4 2012-08-10 04:24:19 PDT
(In reply to comment #2) > (From update of attachment 157697 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157697&action=review > > > LayoutTests/ChangeLog:6 > > + Uneviewed gardening. > > Unreviewed Ouch..
WebKit Review Bot
Comment 5 2012-08-10 06:29:59 PDT
Comment on attachment 157701 [details] patch v2 Clearing flags on attachment: 157701 Committed r125273: <http://trac.webkit.org/changeset/125273>
WebKit Review Bot
Comment 6 2012-08-10 06:30:04 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 7 2012-08-12 23:39:27 PDT
Why would we add a Skipped list? We have been trying to get rid of the one for WebKit1-EFL for several months now. Adding one for WebKit2-EFL really seems like a step backwards. Is there a technical reason not to use a TestExpectations file?
Mikhail Pozdnyakov
Comment 8 2012-08-13 00:06:04 PDT
(In reply to comment #7) > Why would we add a Skipped list? We have been trying to get rid of the one for WebKit1-EFL for several months now. Adding one for WebKit2-EFL really seems like a step backwards. Is there a technical reason not to use a TestExpectations file? I have tried TestExpectations first and it did not work for me, then I noticed that neither mac nor GTK (which does not have Skipped list for WK1 at all) use TestExpectations for WK2. I understand that TestExpectations is better but we need first to provide a fix in scripts to make it work.
Chris Dumez
Comment 9 2012-08-13 00:16:00 PDT
(In reply to comment #8) > (In reply to comment #7) > > Why would we add a Skipped list? We have been trying to get rid of the one for WebKit1-EFL for several months now. Adding one for WebKit2-EFL really seems like a step backwards. Is there a technical reason not to use a TestExpectations file? > > I have tried TestExpectations first and it did not work for me, then I noticed that neither mac nor GTK (which does not have Skipped list for WK1 at all) use TestExpectations for WK2. I understand that TestExpectations is better but we need first to provide a fix in scripts to make it work. Ok, thanks for the explanation. I will try to fix the scripts and use TestExpectations instead in Bug 93796. Qt port is using TestExpectations for WK2 so it is possible.
Note You need to log in before you can comment on or make changes to this bug.