Bug 92597

Summary: In flipped blocks, a point on the top edge of a text box is considered outside the box (and vice versa)
Product: WebKit Reporter: mitz
Component: HTML EditingAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jbadics, leviw, mifenton, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92636, 92662    
Bug Blocks:    
Attachments:
Description Flags
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa none

mitz
Reported 2012-07-29 14:11:43 PDT
This is like bug 92593 but for text boxes. When you drag to select across text in a flipped block, when the mouse pointer is at the top of the line, it’s already selecting the line above.
Attachments
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa (8.74 KB, patch)
2012-07-29 14:19 PDT, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-07-29 14:19:43 PDT
Created attachment 155182 [details] When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa
Ryosuke Niwa
Comment 2 2012-07-29 14:54:27 PDT
Comment on attachment 155182 [details] When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa Makes sense.
Ryosuke Niwa
Comment 3 2012-07-29 14:56:15 PDT
This should probably in the editing for consistency. We should really add a "Hit testing" component.
mitz
Comment 4 2012-07-29 15:56:46 PDT
Fixed in <http://trac.webkit.org/r123988>.
János Badics
Comment 5 2012-07-30 05:23:21 PDT
Unfortunately r123988 made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail on Qt WebKit1. I have created a bug for it on the following link: https://bugs.webkit.org/show_bug.cgi?id=92636
Csaba Osztrogonác
Comment 6 2012-07-30 06:14:20 PDT
Comment on attachment 155182 [details] When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa View in context: https://bugs.webkit.org/attachment.cgi?id=155182&action=review > LayoutTests/fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt:10 > +PASS: offset at (60,24) was 26. This new test case fail on Qt and Chromium Linux too. See the bug report mentioned by the previous comment.
Levi Weintraub
Comment 7 2012-07-30 11:46:31 PDT
Comment on attachment 155182 [details] When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.