Bug 91802

Summary: [chromium] CSS tweaks to media controls to prevent styles from being overridden
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: New BugsAssignee: Andrew Scherkus <scherkus>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, eric.carlson, feature-media-reviews, kbr, macpherson, menard, silviapf, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84672    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-06
none
Fixes the bug
none
Patch
none
Patch eric.carlson: review+

Andrew Scherkus
Reported 2012-07-19 20:28:25 PDT
[chromium] CSS tweaks to media controls to prevent styles from being overridden
Attachments
Patch (48.81 KB, patch)
2012-07-19 20:29 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Patch (48.69 KB, patch)
2012-07-19 20:32 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (458.69 KB, application/zip)
2012-07-19 21:03 PDT, WebKit Review Bot 		no flags
Details
Fixes the bug (4.51 KB, patch)
2012-07-20 00:29 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (7.66 KB, patch)
2012-07-20 11:11 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Patch (7.96 KB, patch)
2012-07-20 11:21 PDT, Andrew Scherkus 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2012-07-19 20:29:04 PDT
Created attachment 153382 [details] Patch
Andrew Scherkus
Comment 2 2012-07-19 20:32:38 PDT
Created attachment 153384 [details] Patch
WebKit Review Bot
Comment 3 2012-07-19 21:03:43 PDT
Comment on attachment 153384 [details] Patch Attachment 153384 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13310096 New failing tests: media/media-document-audio-repaint.html media/video-no-audio.html media/controls-strict.html media/controls-styling.html media/video-display-toggle.html media/audio-repaint.html media/audio-controls-rendering.html media/video-zoom-controls.html media/video-controls-rendering.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html media/video-playing-and-pause.html media/controls-after-reload.html
WebKit Review Bot
Comment 4 2012-07-19 21:03:48 PDT
Created attachment 153389 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Ryosuke Niwa
Comment 5 2012-07-20 00:29:30 PDT
Created attachment 153434 [details] Fixes the bug
Ryosuke Niwa
Comment 6 2012-07-20 00:30:11 PDT
Comment on attachment 153434 [details] Fixes the bug Oops, sorry I somehow used a wrong bug number.
Andrew Scherkus
Comment 7 2012-07-20 10:33:10 PDT
Comment on attachment 153384 [details] Patch the heck!! :) re-opening for review
Andrew Scherkus
Comment 8 2012-07-20 11:11:46 PDT
Created attachment 153544 [details] Patch
Antonio Gomes
Comment 9 2012-07-20 11:14:38 PDT
Comment on attachment 153544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153544&action=review > Source/WebCore/ChangeLog:9 > + [chromium] CSS tweaks to media controls to prevent styles from being overridden > + https://bugs.webkit.org/show_bug.cgi?id=91802 > + > + Reviewed by NOBODY (OOPS!). > + > + Test: media/controls-styling-strict.html > + maybe you should comment why it fixes the bug.
Andrew Scherkus
Comment 10 2012-07-20 11:21:15 PDT
Created attachment 153548 [details] Patch
Andrew Scherkus
Comment 11 2012-07-20 11:21:39 PDT
Comment on attachment 153544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153544&action=review >> Source/WebCore/ChangeLog:9 >> + > > maybe you should comment why it fixes the bug. done
Silvia Pfeiffer
Comment 12 2012-07-20 11:53:56 PDT
LGTM FWIW :-)
Andrew Scherkus
Comment 13 2012-07-20 14:12:19 PDT
Committed r123259: <http://trac.webkit.org/changeset/123259>
Andrew Scherkus
Comment 14 2012-07-20 14:13:41 PDT
*** Bug 89696 has been marked as a duplicate of this bug. ***
Silvia Pfeiffer
Comment 15 2012-08-06 21:15:16 PDT
(Just adding linkage to meta bug.)
Note You need to log in before you can comment on or make changes to this bug.