Bug 91761

Summary:

[CSS Exclusions] SVG shape errors should invalidate exclusion shapes

Product:

WebKit

Reporter:

Bear Travis <betravis>

Component:

CSS

Assignee:

Bem Jones-Bey <bjonesbe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

betravis, cmarcelo, dglazkov, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

89671

Attachments:

Description	Flags
Bug fix	bjonesbe: review-, webkit-ews: commit-queue-
Corrected Bug Fix	none
Updated patch	kling: review+, kling: commit-queue-
Updated patch	none
Updated patch	none
Updated patch	none

Bear Travis

Reported 2012-07-19 10:52:59 PDT

SVG shapes are not valid with certain values (eg, negative width/height) These values should invalidate CSS exclusion shapes as well For the exclusions spec, see: http://dev.w3.org/csswg/css3-exclusions/#shapes-from-svg-syntax For the SVG spec, see: http://www.w3.org/TR/SVG/shapes.html Invalid values Rectangle: negative width, height, rx, ry Circle: negative r Ellipse: negative rx, ry

Attachments
Bug fix (9.12 KB, patch) 2012-07-20 11:20 PDT, Bem Jones-Bey	bjonesbe: review- webkit-ews: commit-queue-	Details Formatted Diff Diff
Corrected Bug Fix (9.16 KB, patch) 2012-07-20 11:57 PDT, Bem Jones-Bey	no flags	Details Formatted Diff Diff
Updated patch (6.99 KB, patch) 2012-07-20 15:20 PDT, Bem Jones-Bey	kling: review+ kling: commit-queue-	Details Formatted Diff Diff
Updated patch (7.14 KB, patch) 2012-07-23 10:53 PDT, Bem Jones-Bey	no flags	Details Formatted Diff Diff
Updated patch (7.18 KB, patch) 2012-07-23 14:48 PDT, Bem Jones-Bey	no flags	Details Formatted Diff Diff
Updated patch (7.11 KB, patch) 2012-07-23 15:59 PDT, Bem Jones-Bey	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Bem Jones-Bey

Comment 1 2012-07-20 11:20:49 PDT

Created attachment 153547 [details] Bug fix CSS exclusion shapes that are specified with negative radiuses or height/width are now considered invalid and ignored.

Early Warning System Bot

Comment 2 2012-07-20 11:24:59 PDT

Comment on attachment 153547 [details] Bug fix Attachment 153547 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13307321

Early Warning System Bot

Comment 3 2012-07-20 11:25:35 PDT

Comment on attachment 153547 [details] Bug fix Attachment 153547 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13315278

WebKit Review Bot

Comment 4 2012-07-20 11:32:41 PDT

Comment on attachment 153547 [details] Bug fix Attachment 153547 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13313276

Bem Jones-Bey

Comment 5 2012-07-20 11:57:43 PDT

Created attachment 153553 [details] Corrected Bug Fix Updated patch that should pass with -Werror=undefined. Maybe the Mac build doesn't have that flag?

Bem Jones-Bey

Comment 6 2012-07-20 15:20:19 PDT

Created attachment 153609 [details] Updated patch Fix tests.

Andreas Kling

Comment 7 2012-07-23 10:27:07 PDT

Comment on attachment 153609 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=153609&action=review r=me though we should really add comments to make it clear why we're selectively disallowing negative numbers. > Source/WebCore/css/CSSParser.cpp:4470 > + if (argumentNumber > 1) > + unitFlags = unitFlags | FNonNeg; Could use a comment - something simple like "// Disallow negative values for width/height." > Source/WebCore/css/CSSParser.cpp:4526 > + if (argumentNumber == 2) > + unitFlags = unitFlags | FNonNeg; Ditto. > Source/WebCore/css/CSSParser.cpp:4573 > + if (argumentNumber > 1) > + unitFlags = unitFlags | FNonNeg; Ditto.

Bem Jones-Bey

Comment 8 2012-07-23 10:53:54 PDT

Created attachment 153819 [details] Updated patch Add requested comments.

Bem Jones-Bey

Comment 9 2012-07-23 14:48:34 PDT

Created attachment 153867 [details] Updated patch Make comments sentences.

Alexandru Chiculita

Comment 10 2012-07-23 14:49:58 PDT

Comment on attachment 153867 [details] Updated patch Adding CQ+.

WebKit Review Bot

Comment 11 2012-07-23 14:51:58 PDT

Comment on attachment 153867 [details] Updated patch Rejecting attachment 153867 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13332120

Bem Jones-Bey

Comment 12 2012-07-23 15:59:20 PDT

Created attachment 153887 [details] Updated patch Automated adding of reviewer didn't work, adding manuallty.

Alexandru Chiculita

Comment 13 2012-07-23 16:00:16 PDT

Comment on attachment 153887 [details] Updated patch Cq+ again.

WebKit Review Bot

Comment 14 2012-07-23 16:56:56 PDT

Comment on attachment 153887 [details] Updated patch Clearing flags on attachment: 153887 Committed r123405: <http://trac.webkit.org/changeset/123405>

WebKit Review Bot

Comment 15 2012-07-23 16:57:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.