Bug 91193

Created attachment 152229 [details] Patch

Created attachment 152231 [details] Patch Remove useless header include.

Created attachment 152232 [details] Patch

Created attachment 152244 [details] Patch Make new ewk header installable.

Created attachment 152303 [details] Patch Rebase on master.

Created attachment 152454 [details] Patch Add destructor for Ewk_Url_Scheme_Request.

Comment on attachment 152454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152454&action=review > Source/WebKit2/ChangeLog:15 > + The client application can now register a URL scheme > + via the Ewk_Context API and provide a callback handler > + that will get called whenever a URL request with this > + scheme is made. > + Did you check how Qt is doing this? I think Zeno made a quite nice API for us, so maybe you should have a look (it is QML based though). I think it was slightly more powerful, but I might be wrong

(In reply to comment #7) > (From update of attachment 152454 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152454&action=review > > > Source/WebKit2/ChangeLog:15 > > + The client application can now register a URL scheme > > + via the Ewk_Context API and provide a callback handler > > + that will get called whenever a URL request with this > > + scheme is made. > > + > > Did you check how Qt is doing this? I think Zeno made a quite nice API for us, so maybe you should have a look (it is QML based though). I think it was slightly more powerful, but I might be wrong Yes, I checked the Qt implementation but I chose to follow the one from GTK port instead. The issue is that the Qt implementation is for QML and it does not closely match what we can/should do in EFL. If you look for example at: Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml Basically, you can define in QML delegates for URL schemes that will return data (and possible a contentType) when a URL request matches one of the schemes. I might be missing something but it does not look more powerful. You can achieve exactly the same thing with the EFL alternative. The major difference is that one is nicely integrated in QML while the other uses the "old" callback way. If I missed something, please tell me.

Let's cc Zeno

Any update on this?

Zeno might be on vacation? Is there any big problem preventing this patch from landing? I mean, we can always improve later if we find missing functionality.

(In reply to comment #11) > Zeno might be on vacation? Is there any big problem preventing this patch from landing? I mean, we can always improve later if we find missing functionality. No, I'm here. Sorry I didn't realize i was cc'ed on this bug. :-) Will read up on it now.

(In reply to comment #9) > Let's cc Zeno Implementation wise it looks similar to what we've done for the Qt port. Of course the API is different, and of course as mentioned before our "callbacks" are meant to be used with QML. Also in this patch i only really see API/port specific code. So I don't think there is much code duplication etc.

r=me

(In reply to comment #14) > r=me Thanks, could you please set r+ flag then? :)

Comment on attachment 152454 [details] Patch sure but I had problems loading the site at work

Comment on attachment 152454 [details] Patch Rejecting attachment 152454 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ager_client.cpp patching file Source/WebKit2/UIProcess/API/efl/ewk_context_request_manager_client_private.h patching file Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request.cpp patching file Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request.h patching file Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request_private.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13330042

Created attachment 153798 [details] Patch for landing Rebase on master.

Comment on attachment 153798 [details] Patch for landing Clearing flags on attachment: 153798 Committed r123341: <http://trac.webkit.org/changeset/123341>

All reviewed patches have been landed. Closing bug.